Skip to content

feat: Passthrough SDK type to Rokt Kit#582

Merged
Mansi-mParticle merged 12 commits into
mParticle:developmentfrom
jamesnrokt:feat/SQDSDKS-7391-Expose-SDK-wrapper
Jun 13, 2025
Merged

feat: Passthrough SDK type to Rokt Kit#582
Mansi-mParticle merged 12 commits into
mParticle:developmentfrom
jamesnrokt:feat/SQDSDKS-7391-Expose-SDK-wrapper

Conversation

@jamesnrokt

@jamesnrokt jamesnrokt commented Jun 11, 2025

Copy link
Copy Markdown
Collaborator

Instructions

  1. PR target branch should be against development
  2. PR title name should follow this format: https://github.com/mParticle/mparticle-workflows/blob/main/.github/workflows/pr-title-check.yml
  3. PR branch prefix should follow this format: https://github.com/mParticle/mparticle-workflows/blob/main/.github/workflows/pr-branch-check-name.yml

Summary

  • Passthrough wrapper SDK type to Rokt kit

Testing Plan

  • Was this tested locally? If not, explain why.
  • {explain how this has been tested, and what, if any, additional testing should be done}

Reference Issue (For mParticle employees only. Ignore if you are an outside contributor)

@jamesnrokt jamesnrokt mentioned this pull request Jun 12, 2025
Merged
1 task
@Mansi-mParticle Mansi-mParticle self-requested a review June 13, 2025 20:37
Mansi-mParticle
Mansi-mParticle approved these changes Jun 13, 2025
View reviewed changes

@Mansi-mParticle Mansi-mParticle left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Mansi-mParticle Mansi-mParticle requested a review from rmi22186 June 13, 2025 20:38
rmi22186
rmi22186 approved these changes Jun 13, 2025
View reviewed changes

@rmi22186 rmi22186 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jamesnrokt - similar situation to iOS, Mansi removed the setWrapper call from MPRokt. since we can do it at the higher mParticle layer. we are only calling it internally ever, so it doesn't need to be on MPRokt explicitly. Having it here would require someone to call it on both MP and MPRokt in order for both SDKs to understand it. Yes the MP layer isn't doing anything with it, but in the future we want it to.

@Mansi-mParticle Mansi-mParticle merged commit 8114d84 into mParticle:development Jun 13, 2025
24 of 34 checks passed
mparticle-automation added a commit that referenced this pull request Jun 14, 2025
@mparticle-automation
chore: 5.68.0 (release)
d40a90e 
## [5.68.0](v5.67.0...v5.68.0) (2025-06-14)

### Features

* Passthrough SDK type to Rokt Kit ([#582](#582)) ([8114d84](8114d84))

### Updates & Maintenance

* Update submodules ([5b7bb9e](5b7bb9e))
@mparticle-automation

mparticle-automation commented Jun 14, 2025

Copy link
Copy Markdown
Collaborator

🎉 This PR is included in version 5.68.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rmi22186 rmi22186 rmi22186 approved these changes
@thomson-t thomson-t thomson-t approved these changes
+1 more reviewer
@Mansi-mParticle Mansi-mParticle Mansi-mParticle approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

released

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@jamesnrokt @mparticle-automation @rmi22186 @thomson-t @Mansi-mParticle